Fix log in iOS11 simulators. #95

KristianDD · 2017-10-03T16:40:25Z

Part of the fix NativeScript/nativescript-cli#3141 (comment)

Fix uses the method described in this example.

KristianDD · 2017-10-09T14:28:38Z

lib/simctl.ts

@@ -120,11 +121,19 @@ export class Simctl implements ISimctl {
 		return devices;
 	}

+	public getLog(deviceId: string): any {
+		return this.simctlSpawn("spawn", [deviceId, "log", "stream"]);


Thank you for the great suggestions, NathanaelA!

I will add --style syslog as this will really make the log very similar to the one in Simulators with previous iOS versions.

I can't add --predicate 'senderImagePath contains "NativeScript" directly as this tool is not framework specific and is published as separate NPM package. I can however add an optional predicate argument to the method.

Mitko-Kerezov · 2017-10-05T07:18:24Z

lib/iphone-simulator-xcode-simctl.ts

+			deviceLogChildProcess = this.getDeviceLogProcess(deviceId);
+			if (deviceLogChildProcess.stdout) {
+				deviceLogChildProcess.stdout.on("data", (data: NodeBuffer) => {
+					let dataAsString = data.toString();


this could be const

Mitko-Kerezov · 2017-10-05T07:39:07Z

lib/iphone-simulator-xcode-simctl.ts

+			if (deviceLogChildProcess.stderr) {
+				deviceLogChildProcess.stderr.on("data", (data: string) => {
+					let dataAsString = data.toString();
+					if (pid) {


Provided that we log the data regardless of whether you enter the if or the else I'd suggest we remove the filter as a whole.
The code could be narrowed down to:

deviceLogChildProcess.stderr.on("data", (data: string) => { process.stdout.write(data.toString()); });

Discussed with @rosen-vladimirov and actually the logging outside the if and else statements is a mistake. Will fix it.

Mitko-Kerezov · 2017-10-05T07:48:22Z

lib/iphone-simulator-xcode-simctl.ts

 	}

 	public getDeviceLogProcess(deviceId: string): any {
-		return common.getDeviceLogProcess(deviceId);
+		const device = this.getDeviceFromIdentifier(deviceId) || {};
+		const deviceVersion = this.getDeviceFromIdentifier(deviceId).runtimeVersion || "";


You can use device here
const deviceVersion = device.runtimeVersion || "";

Mitko-Kerezov · 2017-10-05T07:49:03Z

lib/iphone-simulator-xcode-simctl.ts

+			if(majorVersion && parseInt(majorVersion) >= 11) {
+				this.deviceLogChildProcess = this.simctl.getLog(deviceId);
+			} else {
+				let logFilePath = path.join(osenv.home(), "Library", "Logs", "CoreSimulator", deviceId, "system.log");


This could be const

Mitko-Kerezov · 2017-10-05T08:13:34Z

lib/iphone-simulator-xcode-simctl.ts

 	}

 	public getDeviceLogProcess(deviceId: string): any {
-		return common.getDeviceLogProcess(deviceId);
+		const device = this.getDeviceFromIdentifier(deviceId) || {};


The initialization of these variables can be done inside the if statement down below, because they're only used there

Mitko-Kerezov · 2017-10-05T08:17:25Z

lib/simctl.ts

 			return result.stdout.toString().trim();
 		}
 		return '';
 	}
+
+	private simctlSpawn(command: string, args: string[], opts?: any): any {


The return type here can be narrowed to child_process.ChildProcess instead of any

In addition, you can specify opts?: child_process.SpawnOptions instead of opts?: any

Mitko-Kerezov · 2017-10-10T11:33:49Z

lib/iphone-simulator-xcode-simctl.ts

+			}
+
+			if (deviceLogChildProcess.stderr) {
+				deviceLogChildProcess.stderr.on("data", (data: string) => {


The event handlers for deviceLogChildProcess.stderr.on("data" and deviceLogChildProcess.stdout.on("data" are identical - you can extract the handler as a separate function and pass it to both cases

Mitko-Kerezov · 2017-10-10T11:34:51Z

lib/simctl.ts

@@ -120,11 +121,25 @@ export class Simctl implements ISimctl {
 		return devices;
 	}

+	public getLog(deviceId: string, predicate?: string): any {


The return type here is child_process.ChildProcess

Mitko-Kerezov · 2017-10-10T11:35:13Z

lib/iphone-simulator-xcode-simctl.ts

 	}

-	public getDeviceLogProcess(deviceId: string): any {
-		return common.getDeviceLogProcess(deviceId);
+	public getDeviceLogProcess(deviceId: string, predicate?: string): any {


The return type here is child_process.ChildProcess

Mitko-Kerezov · 2017-10-10T11:35:32Z

lib/iphone-simulator-xcode-simctl.ts

@@ -116,11 +120,64 @@ export class XCodeSimctlSimulator extends IPhoneSimulatorNameGetter implements I
 	}

 	public printDeviceLog(deviceId: string, launchResult?: string): any {


You can change the return type to child_process.ChildProcess here as well

Mitko-Kerezov · 2017-10-10T11:38:14Z

lib/simctl.ts

+	public getLog(deviceId: string, predicate?: string): any {
+		let predicateArgs: string[] = [];
+
+		if (!_.isUndefined(predicate)) {


I think a simple check like if (predicate) { would suffice here, but this is a personal preference

Mitko-Kerezov

Looks okay to me

KristianDD mentioned this pull request Oct 3, 2017

Fix iOS11 Simulator logs NativeScript/nativescript-cli#3145

Merged

KristianDD self-assigned this Oct 3, 2017

KristianDD added the bug label Oct 3, 2017

NathanaelA reviewed Oct 4, 2017

View reviewed changes

Mitko-Kerezov suggested changes Oct 5, 2017

View reviewed changes

Mitko-Kerezov suggested changes Oct 10, 2017

View reviewed changes

KristianDD force-pushed the kddimitrov/ios11-xcode9 branch from f9a812e to 56db899 Compare October 11, 2017 12:36

Mitko-Kerezov approved these changes Oct 12, 2017

View reviewed changes

Kristian D. Dimitrov added 2 commits October 12, 2017 17:36

Fix log in iOS11 simulators.

cc6995e

Fix comments for iOS11 Simulator log.

f2ccf13

KristianDD force-pushed the kddimitrov/ios11-xcode9 branch from 56db899 to f2ccf13 Compare October 12, 2017 16:19

Bump version to 3.2.0

65f86ef

Mitko-Kerezov merged commit 5153663 into master Oct 13, 2017

Mitko-Kerezov deleted the kddimitrov/ios11-xcode9 branch October 13, 2017 11:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix log in iOS11 simulators. #95

Fix log in iOS11 simulators. #95

KristianDD commented Oct 3, 2017

This comment was marked as abuse.

KristianDD Oct 9, 2017

Mitko-Kerezov Oct 5, 2017

Mitko-Kerezov Oct 5, 2017

KristianDD Oct 9, 2017

Mitko-Kerezov Oct 5, 2017

KristianDD Oct 9, 2017

Mitko-Kerezov Oct 5, 2017

Mitko-Kerezov Oct 5, 2017

Mitko-Kerezov Oct 5, 2017

Mitko-Kerezov Oct 5, 2017

KristianDD Oct 9, 2017

Mitko-Kerezov Oct 10, 2017

Mitko-Kerezov Oct 10, 2017

Mitko-Kerezov Oct 10, 2017

Mitko-Kerezov Oct 10, 2017

Mitko-Kerezov Oct 10, 2017

Mitko-Kerezov left a comment

		@@ -116,11 +120,64 @@ export class XCodeSimctlSimulator extends IPhoneSimulatorNameGetter implements I
		}

		public printDeviceLog(deviceId: string, launchResult?: string): any {

Fix log in iOS11 simulators. #95

Fix log in iOS11 simulators. #95

Conversation

KristianDD commented Oct 3, 2017

This comment was marked as abuse.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mitko-Kerezov left a comment

Choose a reason for hiding this comment